-
Notifications
You must be signed in to change notification settings - Fork 120
feat(layout): add LayoutPolar
#355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LayoutPolar (削除ここまで)LayoutPolar (追記ここまで)
Looks good so far.
If you could add an example in examples/, then I can expand the mdBook such that it is also included in the book.
3d76518 to
471e9f0
Compare
0940572 to
bb46ac6
Compare
LayoutPolar (削除ここまで)LayoutPolar (追記ここまで)
f5a7957 to
49e9132
Compare
Ok, I finally have green tests using --features=chromedriver,webdriver_download, so I think I'm happy for a review when you have time.
I noticed while adding a layout to the ScatterPolar example that it's the only one without an ANCHOR comment tag—not sure if that's intentional or not.
49e9132 to
94ef5f3
Compare
Ok, I finally have green tests using
--features=chromedriver,webdriver_download, so I think I'm happy for a review when you have time.I noticed while adding a layout to the
ScatterPolarexample that it's the only one without anANCHORcomment tag—not sure if that's intentional or not.
I will review it this weekend. I will check the Anchor. It is needed for inclusion in the book. I need to see if it is an omission or international.
Thank you very much for the PR!
94ef5f3 to
876e858
Compare
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
795b181 to
9d13249
Compare
Looks good. Merging it. I will make a new release soon.
Uh oh!
There was an error while loading. Please reload this page.
Happy for any feedback/advice while I work on this. Eventually closes #352.